Skip to content

on error, retry getting valid data from sensor#12

Closed
airbjorn wants to merge 2 commits intohackair-project:masterfrom
airbjorn:master
Closed

on error, retry getting valid data from sensor#12
airbjorn wants to merge 2 commits intohackair-project:masterfrom
airbjorn:master

Conversation

@airbjorn
Copy link
Copy Markdown

I tested with my SDS011 sensor. In error case, the hackAIR system interprets the data as a transmitted 0µg measurement for both PM10 and PM25. This leads to an unrealistic data base!
Fix: For these cases and as a general improvement of the example, lets examine the error code!
Note: presumably, the Wemos D1 example should be modified also!

I tested with my SDS011 sensor. In error case, the hackAIR system interprets the data as a transmitted 0µg measurement for both PM10 and PM25. This leads to an unrealistic data base!
Fix: For these cases and as a general improvement of the example, lets examine the error code!
Note: presumably, the Wemos D1 example should be modified also!
on error, retry getting valid data from sensor
@airbjorn
Copy link
Copy Markdown
Author

airbjorn commented Mar 28, 2018

Note: By mistake I've created two commits for the same change, so one is redundant and can be ignored. Both commits of this pull request refer to the exact same modification.

@thgeorgiou
Copy link
Copy Markdown
Member

Overall this seems like a good change, I am slightly worried that it's possible for it to fall into an infinite loop of trying to measure and failing. I will add a counter and after some tries we should send a request with the error flag so the platform can warn the user the sensor is not working correctly.

@airbjorn
Copy link
Copy Markdown
Author

The pull request now is open for some time. Would you mind adapting the Wemos changes to the WiFiShield examples also?
However, I would be fine with maintaining the WiFiShield code in parallel if you grant the permission for me.

@airbjorn
Copy link
Copy Markdown
Author

Closing this request due to missing interest. Will come back some time with another proposal.

@airbjorn airbjorn closed this May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants