ExtractMatcher (Second-order matcher)#45
Closed
joao-de-melo wants to merge 1 commit intohamcrest:masterfrom
Closed
ExtractMatcher (Second-order matcher)#45joao-de-melo wants to merge 1 commit intohamcrest:masterfrom
joao-de-melo wants to merge 1 commit intohamcrest:masterfrom
Conversation
Contributor
|
This looks to be functionally equivalent to the FeatureMatcher class. Although I prefer the idea of composing this functionality from a Function and Matcher as you have done, I'm not keen on defining a Function type in Hamcrest. There are already many incompatible definitions of Function in the Java world. Until Hamcrest supports Java 8 I'd rather this functionality was implemented as an adaptor library that let you use, say, Guava's Function type. |
Contributor
|
Postponed until Hamcrest supports Java 8. Until then, should be an auxiliary library. |
|
I've released Hamcrest Compose which provides a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More information: http://jmelo.lyncode.com/hamcrest-second-order-matcher-a-missing-matcher/