Skip to content

ExtractMatcher (Second-order matcher)#45

Closed
joao-de-melo wants to merge 1 commit intohamcrest:masterfrom
joao-de-melo:second-order-matcher
Closed

ExtractMatcher (Second-order matcher)#45
joao-de-melo wants to merge 1 commit intohamcrest:masterfrom
joao-de-melo:second-order-matcher

Conversation

@joao-de-melo
Copy link
Copy Markdown

@npryce
Copy link
Copy Markdown
Contributor

npryce commented Jan 3, 2014

This looks to be functionally equivalent to the FeatureMatcher class.

Although I prefer the idea of composing this functionality from a Function and Matcher as you have done, I'm not keen on defining a Function type in Hamcrest. There are already many incompatible definitions of Function in the Java world. Until Hamcrest supports Java 8 I'd rather this functionality was implemented as an adaptor library that let you use, say, Guava's Function type.

@npryce
Copy link
Copy Markdown
Contributor

npryce commented Dec 23, 2014

Postponed until Hamcrest supports Java 8. Until then, should be an auxiliary library.

@markhobson
Copy link
Copy Markdown

I've released Hamcrest Compose which provides a hasFeature matcher along these lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants