Addressing iOS 11 safeAreaInsets issue with content controllers#77
Merged
Addressing iOS 11 safeAreaInsets issue with content controllers#77
Conversation
Add new menu item controller to tweak transition options in real-time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS 11, there is an issue that can arise where the content controller of the side menu will fail to have its
safeAreaInsetsset properly if thetransitionOptionscontentScaleproperty set to a certain range of values.Through testing, the value range appears to be between 0.87 - 0.91. To combat this for the time being, the default value for
contentScalehas been adjusted from0.88to0.86.A new side menu item has been added to the Sample project that allows users to adjust the
transitionOptionsin real-time, allowing for faster development and tweaking.