Gracefully handle errors when binding SocketCAN fails#1771
Merged
hardbyte merged 2 commits intohardbyte:mainfrom Jun 18, 2024
Merged
Gracefully handle errors when binding SocketCAN fails#1771hardbyte merged 2 commits intohardbyte:mainfrom
hardbyte merged 2 commits intohardbyte:mainfrom
Conversation
The parent class BusABC expects to be shutdown properly, checked via its self._is_shutdown flag during object deletion. But that flag is only set when the base class shutdown() is called, which doesn't happen if instantiation of the concrete class failed in can.Bus(). So there is no way to avoid the warning message "SocketcanBus was not properly shut down" if the constructor raised an exception. This change addresses that issue for the SocketCAN interface, by catching an OSError exception in bind_socket(), logging it, and calling self.shutdown().
This was referenced Apr 24, 2024
Contributor
Author
|
The alternative approach is now proposed in #1774. This PR could still be useful in addition, to have a proper error log message. If that is desired... |
hardbyte
approved these changes
Apr 29, 2024
Owner
hardbyte
left a comment
There was a problem hiding this comment.
Happy to merge this too - perhaps remove the comment and the shutdown call
Contributor
Author
|
Adjusted as requested. Thanks for your consideration. |
Contributor
Author
|
Ping @hardbyte, want to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parent class
BusABCexpects to be shutdown properly, checked via itsself._is_shutdownflag during object deletion. But that flag is only set when the base class'shutdown()is called, which doesn't happen if instantiation of the concrete class failed incan.Bus(). So there is no way to avoid the warning message "SocketcanBus was not properly shut down" if the constructor raised an exception.This change addresses that issue for the SocketCAN interface, by catching an OSError exception in
bind_socket(), logging it, and callingself.shutdown()before re-raising the exception.There might be a better approach which also works for the other backends? The flag could be initialized to
Trueand only reset toFalsewhen theBusABCconstructor runs (which happens last in derived classes)?Thus leaving this as a draft for further discussion.