Skip to content

Adding neovi device serial base 36 decoding when needed#250

Merged
hardbyte merged 1 commit intohardbyte:developfrom
pierreluctg:neovi_serial_base36
Feb 17, 2018
Merged

Adding neovi device serial base 36 decoding when needed#250
hardbyte merged 1 commit intohardbyte:developfrom
pierreluctg:neovi_serial_base36

Conversation

@pierreluctg
Copy link
Copy Markdown
Collaborator

ICS NeoVi device serial above A0000 are base36 encoded and need to be decoded properly.

@pierreluctg
Copy link
Copy Markdown
Collaborator Author

pierreluctg commented Feb 13, 2018

@hardbyte can we include this one in the 2.1.0 release?

Thank you

@hardbyte hardbyte added this to the 2.1 Release milestone Feb 17, 2018
Copy link
Copy Markdown
Owner

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hardbyte hardbyte merged commit 10aef50 into hardbyte:develop Feb 17, 2018
@pierreluctg pierreluctg deleted the neovi_serial_base36 branch February 23, 2018 20:25
boris-wenzlaff pushed a commit to boris-wenzlaff/python-can that referenced this pull request Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants