SocketCAN (native) cyclic improvements#323
Merged
christiansandberg merged 3 commits intohardbyte:developfrom Jun 12, 2018
Merged
SocketCAN (native) cyclic improvements#323christiansandberg merged 3 commits intohardbyte:developfrom
christiansandberg merged 3 commits intohardbyte:developfrom
Conversation
Use BCM for setting duration
felixdivo
approved these changes
Jun 12, 2018
| :param channel: The name of the CAN channel to connect to. | ||
| :param message: The message to be sent periodically. | ||
| :param period: The rate in seconds at which to send the message. | ||
| """ |
Collaborator
There was a problem hiding this comment.
maybe add the param to the docs here
| @@ -262,7 +274,10 @@ def modify_data(self, message): | |||
| Note the Message must have the same :attr:`~can.Message.arbitration_id`. | |||
Collaborator
There was a problem hiding this comment.
... "like the one of the message given in the constructor"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep periodic transmission timing on data update.
Use BCM for setting duration.
Fixes #298.