Adding proper bitrate and timestamp support for neovi#324
Merged
felixdivo merged 4 commits intohardbyte:developfrom Jun 14, 2018
pierreluctg:python-ics-2.12
Merged
Adding proper bitrate and timestamp support for neovi#324felixdivo merged 4 commits intohardbyte:developfrom pierreluctg:python-ics-2.12
felixdivo merged 4 commits intohardbyte:developfrom
pierreluctg:python-ics-2.12
Conversation
felixdivo
approved these changes
Jun 12, 2018
Collaborator
felixdivo
left a comment
There was a problem hiding this comment.
This looks way more elegant/simple
Collaborator
Author
|
FYI @hardbyte |
Collaborator
|
Can this be tested in some way with unit tests? |
Collaborator
Author
|
@felixdivo not really unit testable without python-ics, icsneo40 dll and NeoVi device (this is no longer unit test) or python-ics and a icsneo40 mock dll |
Collaborator
|
Okay. Maybe we should add a mock dll at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.