Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #428 +/- ##
==========================================
Coverage ? 62.29%
==========================================
Files ? 55
Lines ? 4612
Branches ? 0
==========================================
Hits ? 2873
Misses ? 1739
Partials ? 0 |
Collaborator
|
Yeah, all of them should respond with error 22. The error is this one: The help is printed to the console anyways. |
99d4de8 to
e7ff9a8
Compare
e7ff9a8 to
ce5ac4b
Compare
felixdivo
reviewed
Sep 27, 2018
| .. autoclass:: can.BusABC | ||
| :private-members: | ||
| :special-members: | ||
| :noindex: |
Collaborator
There was a problem hiding this comment.
This fixes some of the Sphinx errors, but adds
WARNING: py:meth reference target not found: can.BusABC._apply_filters
for all "private" methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed we had a lot of direct command line output in our docs - there is a sphinx plugin that will extract that for us.
I didn't use it on thecan.vieweras it returns an error code - see #427