Merged
Conversation
This PR removes [this `DeprecationWarning`](https://travis-ci.org/hardbyte/python-can/jobs/529939236#L473): > invalid escape sequence \c Is this correct to to? It now is like [this example](https://docs.microsoft.com/en-us/windows/desktop/wmisdk/swbemlocator-connectserver#examples).
Codecov Report
@@ Coverage Diff @@
## develop #570 +/- ##
========================================
Coverage 63.99% 63.99%
========================================
Files 63 63
Lines 5572 5572
========================================
Hits 3566 3566
Misses 2006 2006 |
Collaborator
Author
Contributor
|
I haven't had a chance to test this yet. If all goes well I will check back next week. |
Collaborator
Author
|
@acolomb Did it work? |
Contributor
|
Sorry I didn't get a chance to test it yet. Way too much work just before a longer vacation... Will report when tested, but that might be a couple of weeks now. |
hardbyte
approved these changes
May 19, 2019
Collaborator
Author
|
I am pretty sure this is a correct fix. I'll merge this for now. Please report back if it breaks something. |
Contributor
|
So I tested this now with a real USB2CAN hardware device. Successfully opened the backend without specifying a serial number prefix, therefore the adapter was correctly autodetect even with this change. Works as expected, sorry for the long delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes this
DeprecationWarning:Is this correct to do? It now is like this example.
Closes #576.