fix: plugin does not load when helm base dir contains space#10913
Merged
mattfarina merged 2 commits intohelm:mainfrom Sep 18, 2023
Merged
fix: plugin does not load when helm base dir contains space#10913mattfarina merged 2 commits intohelm:mainfrom
mattfarina merged 2 commits intohelm:mainfrom
Conversation
|
Did you forget Line 152 in 699ea6d ? I guess, someone would ask for unit tests here. |
d3d9cda to
813288d
Compare
Signed-off-by: Suresh Kumar <[email protected]>
Member
|
@sureshdsk Thanks very much. need some unittest for this pr. |
Signed-off-by: Suresh Kumar <[email protected]>
Contributor
Author
|
@yxxhero I've added tests. can you take a look? |
Contributor
Author
|
@yxxhero its been a while. just following up. do you want review it or assign the code review to someone? |
joejulian
approved these changes
Sep 19, 2022
Contributor
joejulian
left a comment
There was a problem hiding this comment.
This looks good to me, but I'm not a maintianer.
mattfarina
approved these changes
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Suresh Kumar [email protected]
What this PR does / why we need it:
closes #10884
bug: plugin does not work when HELM_DATA_HOME directory path contains spaces
solution:
existing method expands env variable and then splits command sequence by space. if the path contains space, results in error. so expanding just before executing the command fixes the issue.
If applicable: