This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Add methods for the kind of op instead of using is expressions#18
Closed
fredemmott wants to merge 1 commit intohhvm:masterfrom
Closed
Add methods for the kind of op instead of using is expressions#18fredemmott wants to merge 1 commit intohhvm:masterfrom
is expressions#18fredemmott wants to merge 1 commit intohhvm:masterfrom
Conversation
facebook-github-bot
left a comment
There was a problem hiding this comment.
@fredemmott has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This is a > 75% speedup for `getUnifiedDiff(string $a, string $b)` on large files when not running in repo-auth mode.
cc8c1f2 to
df3d85a
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
@fredemmott has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@fredemmott merged this pull request in df993ab. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a > 75% speedup for
getUnifiedDiff(string $a, string $b)onlarge files when not running in repo-auth mode.