Improve TimeBooking Graph Performance#88
Merged
mstarke merged 1 commit intonext-versionfrom Dec 19, 2018
Merged
Conversation
jume-dev
suggested changes
Oct 16, 2018
jume-dev
left a comment
There was a problem hiding this comment.
As this is an added library it's advisable to maybe to a pull request to here: https://github.com/jqPlot/jqPlot/ and while waiting for acceptance, use the files from your fork with proper versioning.
This way the chance is higher, that this fix won't be lost on the next update for this library.
Contributor
Author
|
I agree, i will make a pull request there tomorrow. |
Contributor
Author
|
Pending: jqPlot/jqPlot#180 |
Member
|
@strfry Can you try to push for the merge on jqPlot so we don't have to roll our own version? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch should improve graph rendering on large time scales. It avoids triggering the browser to re-layout for each of thousands of invisible date markers / ticks.
Still not great, but much better than before.