Add add_flex action and error logging for possible environment variable typos #162
Merged
boegel merged 21 commits intohpcugent:masterfrom Apr 21, 2015
Merged
Conversation
…ironment variables that look like but are not a valid option
|
Refer to this link for build results (access rights to CI server needed): |
Member
Author
|
@boegel this should be sufficient for the EB issues you wanted |
Member
There was a problem hiding this comment.
drop silly-named and not even used emptyisNone
Member
Author
There was a problem hiding this comment.
it's there for future extensions
Member
There was a problem hiding this comment.
extensions of what?
don't include code you're not actually using, it looks silly
boegel
added a commit
to boegel/easybuild-framework
that referenced
this pull request
Apr 2, 2015
Member
|
still fixes and moar tests via stdweird#4 (also fixing the merge conflict on the vsc-base version) |
Member
|
@stdweird: I ran into a potential issue when writing up the unit tests for EB's |
boegel
added a commit
to boegel/easybuild-framework
that referenced
this pull request
Apr 2, 2015
…igfiles sync with master, bump version to 2.2.0, style fixes, enhance tests
Member
Author
|
@boegel rereview or merge |
|
Refer to this link for build results (access rights to CI server needed): |
Member
…igfiles add unit test to test behaviour with specifying 'add' options multiple times
|
Refer to this link for build results (access rights to CI server needed): |
Member
Author
|
@boegel bug is pretty stupid, not sure about the fix yet |
Member
|
"Would you like to know more?" clicks yes |
Member
|
fix for the bug that is blocking this in https://github.com/stdweird/vsc-base/pull/6/files |
…igfiles fix take_action for add* typed values
|
Refer to this link for build results (access rights to CI server needed): |
Conflicts: setup.py
…igfiles sync with master
|
Refer to this link for build results (access rights to CI server needed): |
Member
|
Going in (finally), thanks @stdweird for looking into this! |
boegel
added a commit
that referenced
this pull request
Apr 21, 2015
…configfiles Add add_flex action and error logging for possible environment variable typos
sylmarien
pushed a commit
to ULHPC/modules
that referenced
this pull request
May 11, 2015
7120749 Adding ThematicMNS c943b20 Merge branch 'master' into develop 57d8de9 bump version to v2.2.0dev 78c7289 Merge pull request #1272 from hpcugent/develop aefd06b bump version to v2.1.1dev 6336dcf Merge pull request #1266 from boegel/eb210 7c4b0e6 fix typo e4205d6 include PRs #1169 and #1270 in release notes abfe7d9 Merge pull request #1270 from boegel/fix_lua_help b13963c Merge pull request #1169 from geimer/tsv_skip_checksum_verification a2887f8 fix broken test aea378c fix help statement in Lua module files 4bd89f3 Merge pull request #1 from boegel/tsv_skip_checksum_verification f136347 fix broken tests: don't try setting unknown easyconfig parameter via --try-amend, due to changes in tweak_one ad5351e really fix date d785934 add docs URLs, list vsc-base enhancements, fix date 7b774e1 include PR #1268 in release notes 5ecf685 Merge pull request #1268 from boegel/craype_error 1e1e917 check whether craype exists before loading it bd2ed2c include PR #1267 ca3f1d8 Merge pull request #1267 from boegel/job_opts a7c147e enhance tests 4aca5ef do not fiddle with options.self.options.external_modules_metadata if --external-modules-metadata was not set 8c47e70 Merge branch 'develop' into eb210 0045e09 Merge pull request #1234 from pforai/cray 51533c9 bump version to 2.1.0 and update release notes cd83a05 Merge pull request #40 from boegel/cray 2beac2e also include mpich-mt in list of CrayPE compiler flags e966e71 Merge pull request #39 from boegel/cray 80b6311 Merge branch 'develop' into cray f7fe6d0 Merge pull request #1265 from boegel/external_modules_metadata 881ec3c Merge branch 'develop' into cray 58d84b6 Merge pull request #38 from boegel/cray ace0f89 tiny fixes d65dd6e Merge pull request #37 from boegel/cray fdcfbfa fix typo fd625b3 rename CrayPEMPI to CrayMPICH 2500a00 exclude cray-libsci from toolchain definition 3dbfe72 fix issues w.r.t. precision compiler flags ec21181 push up experimental 20186ec refactor Cray support in separate modules for different toolchain components 7900c3f Merge branch 'cray' of github.com:pforai/easybuild-framework into cray fcda0a9 remove unused usewrappercompiler option bbbceb1 fix broken tests f100ddb fix remarks 9f7593c fix parsing of external modules metadata, make sure name/version are always lists 5ee5bc9 Merge pull request #1018 from boegel/only_module 3483e4c Merge pull request #36 from boegel/cray 7cccdb7 define toolchain_family to be used in easyblocks 30eaa09 drop --software-installdir-naming-scheme, extend MNS API with det_install_subdir 4141c21 rename to --module-only fix style remarks, force Tcl syntax in --module-only unit test fee2b98 add support for --software-installdir-naming-scheme, enhance test for --only-module 54e7297 clean up implementation of --only-module, add unit test for it 803eacf Merge branch 'develop' into only_module 7b1b258 added fixme wrt to hugepage and accelerator targets 6f0c2f6 One more FIXME for MT BLAS. 8d6cb42 Merge pull request #35 from boegel/cray 70801ed add FIXMEs 8d58f8d Merge pull request #34 from boegel/cray 4638950 handle possible list of names for external modules in _add_dependency_variables 8281b32 fix broken test + minor cleanup 5f96460 cleanup handling of external modules in toolchain.prepare fcc352b Merge branch 'develop' into cray 4d5d816 remove unused pre_prepare hackish workaround c9e3f73 define $EB* env vars for external modules via toolchain prepare mechanism 5d31d96 style fixes + better logging 603a224 enhance test for parsing deps in easyconfig 1b5d84c fix remarks 86b9316 Merge pull request #1264 from boegel/PROFILEREAD fd246c9 add support for --external-modules-metadata, pick up metadata when parsing dependencies ab980db get rid of $PROFILEREAD hack when running commands, not needed anymore b2dd119 Merge pull request #33 from boegel/cray fe9d9e6 set correct compiler/MPI family for Cray toolchains f6471ac use PrgEnv as compiler module name, don't redefine toolchain definition as being empty 00f374c avoid issue with _set_compiler_flags super call wrt multiple inheritance (-dynamic appearing multiple times in $CFLAGS) eabe2e8 Merge pull request #32 from boegel/cray c9c8208 Merge branch 'develop' into cray 8fd7d01 Merge pull request #1263 from boegel/joinfix 278e3fa use setdefault 06eaa6d Merge pull request #31 from boegel/cray 96aac6f use empty BLAS_LIB/BLAS_LIB_MT lists (required #1263) 69f6f91 drop 'wrapper' lingo 066c8ae fix dealing with empty variables in Variables.join method 3822c1f Merge branch 'develop' into cray 064db93 Merge pull request #1253 from boegel/error_on_env_var_cfg_typo 967952e Merge pull request #1252 from boegel/flex_robot_paths 62352ac Merge pull request #1230 from boegel/support_system_modulefiles 3586bbc fix dep_graph w.r.t. external modules 59f36bf fix indendation issue in options unit test module 23ed6c5 fix test cases w.r.t. flex aspect of --robot-paths 205e3cf fix remark and remaining KeyError issue 897e0be broken KeyError issue 0f15d9f add support for marking dependencies as external modules bdebab6 remove system_modules parameter/option ebbb5e6 Merge branch 'develop' into support_system_modulefiles 5300bfb Merge branch 'develop' into error_on_env_var_cfg_typo 65a0733 Merge branch 'develop' into flex_robot_paths 273ae08 Merge pull request #30 from boegel/cray bdc29a3 play around with compiler flags and toolchain options, to make HPL+zlib+Szip work 1a5aa95 Merge pull request #29 from boegel/cray 6ca5e1f update Cray toolchain support for make HPL build work 58e626a Merge pull request #28 from boegel/cray dc823dc Merge branch 'develop' into cray a09e87d Merge pull request #1262 from boegel/fix_tests 4c1109d Merge pull request #27 from boegel/cray 4e0d305 make sure both vsc-base and easybuild-framework are included in $PYTHONPATH in scripts tests a8654a8 reload tools.options after unsetting $XDG* env vars in test 081a926 replace log.error with raise EasyBuildError cea8efe Merge branch 'develop' into cray fdcde97 Fixed error in GNU wrapper to really use GCC instead of IntelIccIfort's CC and friends. 3cdc650 avoid reusing same values in --robot-paths test 3de5b09 Merge pull request #26 from boegel/cray ea758b9 Merge branch 'develop' into cray 00e923a Merge branch 'develop' into error_on_env_var_cfg_typo 06f0e91 use new raise_easybuilderror function to report detection of use of unknown $EASYBUILD env vars 0f4953b enable detection of use of unknown $EASYBUILD-prefixed env vars 3c3b26f require vsc-base 2.2.0 (see hpcugent/vsc-base#162) 13358e5 add support for appending/prepending to --robot-paths to avoid destroying the default 16564b9 require vsc-base 2.2.0 (see hpcugent/vsc-base#162) 4ea5557 Rebased to current develop. Merge branch 'develop' of github.com:hpcugent/easybuild-framework into cray 0a3627c Restored run.py for cleanup. bef539c Cleanup for PR, restored dummy dummy semantics. f57e704 Removed the script to initially generated the TC configs as this isnt needed at all. a55bee6 Merge pull request #17 from boegel/cray b77ff5e style cleanup and FIXMEs 7df15fc error out when optarch build option is not set for Cray toolchain 92e33c9 move definitions of PRGENV_MODULE_NAME_SUFFIX to right location 9c78309 Merge pull request #16 from boegel/cray 8227cda fix COMPILER_MODULE_NAME for Cray toolchains 6dc04a5 fix format issue for craype module 64d7da7 pick craype module based on 'optarch' build option, and load it e6c836b Merge pull request #15 from boegel/cray 69854f1 load PrgEnv module via toolchain.prepare method 456a9d7 tabs are evil ad1ce3e Merge pull request #14 from boegel/cray 87ca854 rename Cray toolchains 440922a remove system_modules stuff 028eeb2 Merge pull request #13 from boegel/cray 8dfa420 Merge branch 'develop' into cray 7222406 add support for --system-modules + unit test for use of system modules via EB config/easyconfig ce0feec rebased on ugent develop c869aff Initial support for non-EB generated system module files. 0d8379e Merge branch 'develop' into only_module 8ec281e Merge branch 'develop' of github.com:hpcugent/easybuild-framework into cray d9adc46 Merge branch 'develop' of github.com:hpcugent/easybuild-framework into cray b5d67f0 First working version of using the wrappers internal compiler. 5bae9a3 Merge branch 'develop' of github.com:hpcugent/easybuild-framework into cray 0b19f94 Some TC dickery. b15b395 Pre Kenneth fixes. bd7c8cf Merge branch 'develop' of github.com:hpcugent/easybuild-framework into cray bcb5fdc initial commit. 3a6a8c6 Clear checksums when using '--try-software-version' a169c98 Merge branch 'develop' of github.com:hpcugent/easybuild-framework into cray ba81162 Merge branch 'develop' of github.com:hpcugent/easybuild-framework into cray 0fffa3b Merge branch 'develop' of github.com:hpcugent/easybuild-framework into cray 152795d Merge branch 'develop' of github.com:hpcugent/easybuild-framework 94535f6 Merge branch 'develop' into only_module 5205707 add support for only (re)generating module file git-subtree-dir: easybuild/easybuild-framework git-subtree-split: 7120749d11b248445de3424b1e95a2d5cd9b7d4b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #161