Fixing SVG close tag bug#144
Closed
sdcooke wants to merge 1 commit intohtml5lib:masterfrom
sdcooke:svg_close_tags2
Closed
Fixing SVG close tag bug#144sdcooke wants to merge 1 commit intohtml5lib:masterfrom sdcooke:svg_close_tags2
sdcooke wants to merge 1 commit intohtml5lib:masterfrom
sdcooke:svg_close_tags2
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/930 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
gsnedders
added a commit
to gsnedders/html5lib-python
that referenced
this pull request
Dec 16, 2015
Member
|
See #221 instead of this, which fixes this as the spec does. |
gsnedders
added a commit
to gsnedders/html5lib-python
that referenced
this pull request
Jan 12, 2016
gsnedders
added a commit
that referenced
this pull request
Jan 12, 2016
Fix #144: avoid bogus parse error on camel-case foreign elements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test fails on current master - I'm new to this library so I may have fixed it in the wrong way or missed other places where it would fail but this solves my problem.