Do not directly use isolated surrogates in unicode literals#185
Closed
gsnedders wants to merge 14 commits intohtml5lib:masterfrom
Closed
Do not directly use isolated surrogates in unicode literals#185gsnedders wants to merge 14 commits intohtml5lib:masterfrom
gsnedders wants to merge 14 commits intohtml5lib:masterfrom
Conversation
…orms besides Jython
HTMLUnicodeInputStream objects from unicode strings that contain isolated surrogates. Such tests are not meaningful on Jython which does not allow for invalid unicode strings to be decoded in the first place.
IMO this is a lot more readable.
This also makes it easier to see what's going wrong if something does under Jython.
|
Critic review: https://critic.hoppipolla.co.uk/r/4798 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Member
Author
|
This has landed in the form of b51828b. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This again. Replacement of #150 and #168 .