Skip to content

Drop support for EOL Python 3.3#358

Merged
gsnedders merged 6 commits intohtml5lib:masterfrom
hugovk:rm-3.3
May 23, 2018
Merged

Drop support for EOL Python 3.3#358
gsnedders merged 6 commits intohtml5lib:masterfrom
hugovk:rm-3.3

Conversation

@hugovk
Copy link
Copy Markdown
Contributor

@hugovk hugovk commented Nov 7, 2017

Fixes #357.

@gsnedders
Copy link
Copy Markdown
Member

gsnedders commented Nov 30, 2017

This won't be merged until pip 11 is near release (assuming pip 11 drops support for Python 3.3, as planned).

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 4, 2017 •
edited
Loading

Codecov Report

Merging #358 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files          50       50           
  Lines        6950     6950           
  Branches     1328     1328           
=======================================
  Hits         6308     6308           
  Misses        483      483           
  Partials      159      159

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4887f0...bbd5eb7. Read the comment docs.

@nicktimko
Copy link
Copy Markdown

nicktimko commented Dec 7, 2017

I'd be curious to just leave the test in there but put it in allowed_failures, then once it actually breaks mark 3.3 as unsupported.

@hugovk
Copy link
Copy Markdown
Contributor Author

hugovk commented May 22, 2018

Python 3.3 has now broken. The master branch now fails on Travis CI for all three Python 3.3 jobs:

Collecting wheel
wheel requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*' but the running Python is 3.3.6
----------------------------------------
...Installing setuptools, pip, wheel...done.
Traceback (most recent call last):
  File "/opt/python/3.3.6/lib/python3.3/runpy.py", line 160, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/opt/python/3.3.6/lib/python3.3/runpy.py", line 73, in _run_code
    exec(code, run_globals)
  File "/home/travis/virtualenv/python3.3.6/lib/python3.3/site-packages/virtualenv.py", line 2343, in <module>
    main()
  File "/home/travis/virtualenv/python3.3.6/lib/python3.3/site-packages/virtualenv.py", line 712, in main
    symlink=options.symlink)
  File "/home/travis/virtualenv/python3.3.6/lib/python3.3/site-packages/virtualenv.py", line 947, in create_environment
    download=download,
  File "/home/travis/virtualenv/python3.3.6/lib/python3.3/site-packages/virtualenv.py", line 904, in install_wheel
    call_subprocess(cmd, show_stdout=False, extra_env=env, stdin=SCRIPT)
  File "/home/travis/virtualenv/python3.3.6/lib/python3.3/site-packages/virtualenv.py", line 796, in call_subprocess
    % (cmd_desc, proc.returncode))
OSError: Command /home/travis/build/h.../optional/bin/python - setuptools pip wheel failed with error code 1

https://travis-ci.org/hugovk/html5lib-python/builds/382154525

The newly released pip 10 deprecates 3.3, and it has just been dropped from the codebase: pypa/pip#5423.

@gsnedders gsnedders merged commit 7f613b3 into html5lib:master May 23, 2018
@hugovk hugovk deleted the rm-3.3 branch May 23, 2018 09:59
twm added a commit to twm/html5lib-python that referenced this pull request Jun 10, 2018
@twm
Remove Appveyor Python 3.3 builds
e137495 
It looks like this was missed in html5lib#358. It is causing build failures in html5lib#395 and html5lib#396.
@twm twm mentioned this pull request Jun 10, 2018
Merged
gsnedders pushed a commit that referenced this pull request Oct 1, 2018
@twm @gsnedders
Remove Appveyor Python 3.3 builds (#397)
7facf98 
It looks like this was missed in #358. It is causing build failures in #395 and #396.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gsnedders gsnedders gsnedders approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hugovk @gsnedders @codecov-io @nicktimko