Skip to content

add support for getting issues by milestone and state #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
evanchooly wants to merge 1 commit into from
Closed

add support for getting issues by milestone and state #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>3.8.1</version>
<version>4.11</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
18 changes: 17 additions & 1 deletion src/main/java/org/kohsuke/github/GHMilestone.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package org.kohsuke.github;

import java.io.IOException;
import java.util.Date;
import java.util.Locale;

Expand Down Expand Up @@ -65,7 +66,22 @@ public GHMilestoneState getState() {
return Enum.valueOf(GHMilestoneState.class, state.toUpperCase(Locale.ENGLISH));
}

public GHMilestone wrap(GHRepository repo) {
/**
* Closes this issue.
*/
public void close() throws IOException {
edit("state", "closed");
}

private void edit(String key, Object value) throws IOException {
new Requester(root)._with(key, value).method("PATCH").to(getApiRoute());
}

protected String getApiRoute() {
return "/repos/"+owner.getOwnerName()+"/"+owner.getName()+"/milestones/"+number;
}

public GHMilestone wrap(GHRepository repo) {
this.owner = repo;
this.root = repo.root;
return this;
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/org/kohsuke/github/GHMyself.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import java.util.Arrays;
import java.util.Collections;
import java.util.HashSet;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.Set;
Expand Down Expand Up @@ -45,7 +44,7 @@ public List<GHKey> getPublicKeys() throws IOException {
}

/**
* Returns the read-only list of all the pulic verified keys of the current user.
* Returns the read-only list of all the public verified keys of the current user.
*
* Differently from the getPublicKeys() method, the retrieval of the user's
* verified public keys does not require any READ/WRITE OAuth Scope to the
Expand Down
Loading