Transpile module output for package.json#57
Open
farneman wants to merge 1 commit intohyperform:masterfrom
Open
Transpile module output for package.json#57farneman wants to merge 1 commit intohyperform:masterfrom
farneman wants to merge 1 commit intohyperform:masterfrom
Conversation
c0ba525 to
80fc0de
Compare
Contributor
Author
|
Updated to fix conflicts with the current master. |
|
👍 |
|
We ran into an issue where the es2015 version was always automatically used, even with the |
|
I'm running into an issue with ES2015 version as well (using webpack 4 and the import statement). Can anyone confirm if this PR solves this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #56 by adding an
./esdirectory that is created via NPM'spreparecommand on publish and install. The files from./srcare transpiled to ES5 there via Babel while keeping the module syntax.I also added a similar command to the
Makefileif it's helpful. I'm not very familiar with JSPM or its use of Makefiles so let me know if that needs to be changed or removed.