Add validity class target selector configuration#59
Open
farneman wants to merge 1 commit intohyperform:masterfrom
Open
Add validity class target selector configuration#59farneman wants to merge 1 commit intohyperform:masterfrom
farneman wants to merge 1 commit intohyperform:masterfrom
Conversation
Contributor
Author
|
@Boldewyn would this be something that you would consider adding? |
57eb2aa to
2365ba8
Compare
Contributor
Author
|
I've updated this branch to sync with the current master. |
Contributor
Author
|
@Boldewyn Any chance you would be able to look at this sometime soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
classSelectorconfig option in the form of a function that receives the currently validated element as an argument. If this config option is supplied, it is called and the result is used as the target for adding validity classes. If not the element is used as it presently does. Having this option allows for other common CSS styling patterns that are not possible with only having classes on the actual validated element.I wasn't sure the best place to put the test for this feature, so let me know if I need to move it.