New python:3.7 and renames python:3.6#61
Conversation
473f72c to
a2b4323
Compare
| repo: ibm-functions/runtime-python | ||
| - provider: script | ||
| script: "./tools/travis/publish.sh ibmfunctions $TRAVIS_TAG" | ||
| script: "./tools/travis/publish.sh ibmfunctions 3.6 master && ./tools/travis/publish.sh ibmfunctions 3.7 master " |
There was a problem hiding this comment.
Should 3.6 and 3.7 be hardcoded?
There was a problem hiding this comment.
Yes as this are two different images, and the tools/publish.sh will parse this prefix
| @@ -26,8 +26,9 @@ import org.scalatest.BeforeAndAfterAll | |||
| @RunWith(classOf[JUnitRunner]) | |||
| class CredentialsIBMPythonCOSTests extends TestHelpers with WskTestHelpers with BeforeAndAfterAll with WskActorSystem { | |||
There was a problem hiding this comment.
Seems like all these classes with lazy val defaultKind can be changed to take a kind variable and remove RunWith(classOf[JUnitRunner]).
class CredentialsIBMPythonCOSTests(kind: String)...
There was a problem hiding this comment.
I don't follow
This has being the way we run all our tests multiple times for different kinds, to override certain variables.
The RunWith(classOf[JUnitRunner]) is required so they get pickup by gradle/junit test we can't remove.
This Classes are not called programmatically so a contructor can't be use.
There was a problem hiding this comment.
A constructor can still be used when extending the base class.
abstract class Base(val kind: String) {}
@RunWith(classOf[JUnitRunner])
class ExtendedBase() extends Base(kind = "python:3") {}
dubee
left a comment
There was a problem hiding this comment.
@csantanapr, do all of the runtimes run the same integration tests? If so, it seems like we could have one code base for the tests instead of duplicating code. The fixture extension to use can be determined dynamically based on the kind when the tests run.
|
@dubee there is no duplicate scala tests, the tests just run twice, this is how do it in core and in runtime repos, a base class contains the tests, and another Class with an override property extend the first class. |
|
Looks like the same tests are duplicated across |
|
These look like the same tests to me, but that is a different issue. |
Ah I see a cross runtime repos, yes they are similar and maybe some consolidation can be done.
But I don't think we should block this PR, because of these. |
New runtime for python 3.7
Current python 3.6 changes
pythonnowpython3.6python-jessie:3now kindpython:3.6action-python-v3nowaction-python-v3.6