Support client cert; respect SNI#16
Merged
ickerwx merged 2 commits intoickerwx:masterfrom Jul 1, 2020
AdrianVollmer:client-cert
Merged
Support client cert; respect SNI#16ickerwx merged 2 commits intoickerwx:masterfrom AdrianVollmer:client-cert
ickerwx merged 2 commits intoickerwx:masterfrom
AdrianVollmer:client-cert
Conversation
Clients typically fill in the SNI (server name indication) extension to indicate which (virtual host) they want to connect to, since a server with one IP address can host several virtual servers. Since the args.target_ip variable is always normalized to the IP which the given target resolves to, we use the callback function to retrieve the clients SNI and reuse that hostname when establishing the connection to the target.
Owner
|
Hi Adrian, thanks a lot for that, it looks great. I'll merge everything after I tried it myself, but I won't be able to try this out before the weekend. From looking at the changes I don't think there will be any problems. |
Owner
|
Tested, works, thank you very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does three things:
What do you think?