Disable verification of server cert#22
Merged
ickerwx merged 1 commit intoickerwx:masterfrom Oct 22, 2020
AdrianVollmer:no_verify
Merged
Disable verification of server cert#22ickerwx merged 1 commit intoickerwx:masterfrom AdrianVollmer:no_verify
ickerwx merged 1 commit intoickerwx:masterfrom
AdrianVollmer:no_verify
Conversation
Owner
|
Nah, we don't need a switch for that, I don't see any user of the proxy caring about cert validation. The proxy has enough switches already 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure when this happened, because surely we would have noticed this before, but I couldn't connect to a target service with an unverifiable certificate. I suspect it's this:
This PR disables certificate verification.
Clearly we don't really care about certificate validation. If you disagree, we could create a new parameter
-klike incurl, to disable certificate validation by request and enable it by default.