Add delay packet feature + fix source ip default behavior#43
Merged
ickerwx merged 3 commits intoickerwx:masterfrom May 29, 2024
Merged
Add delay packet feature + fix source ip default behavior#43ickerwx merged 3 commits intoickerwx:masterfrom
ickerwx merged 3 commits intoickerwx:masterfrom
Conversation
Owner
|
Hey, thanks a lot for the PR. I took some time off coding, so this lay here a little while :D All the best and take care. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source ip binding I submitted earlier should be made optional and not added by default. So we removed the default from argparse.
Adding a delay module so we can test some network scenario for an application where the packets arriving are delayed / dropped (if you were to close the proxy before the end of delay feature).