Fix defaults for --sourceip and --sourceport#45
Merged
ickerwx merged 1 commit intoickerwx:masterfrom May 29, 2024
hrzlgnm:master
Merged
Fix defaults for --sourceip and --sourceport#45ickerwx merged 1 commit intoickerwx:masterfrom hrzlgnm:master
ickerwx merged 1 commit intoickerwx:masterfrom
hrzlgnm:master
Conversation
Use falsy values by default, otherwise the proxy thread will always attempt to bind to 0.0.0.0:8080 which in many cases might be already in use.
Owner
|
Hey, sorry for the late response, I took a little time off from programming as a hobby. You know, I just realized that I actually always explicitly specify Thanks for the pull request, it's very much appreciated and I hope my little tool helped you or maybe even continues to help you. All the best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use falsy values by default, otherwise the proxy thread will always attempt to bind to 0.0.0.0:8080 which in many cases might be already in use. Also make the condition an or condition to allow binding to a local ip or a port.
The addition of the --sourceip and --sourceport broke my local setup where I use a custom module to fix hddtemp network output for a specific samsung drive by removing the garbage from a non properly null terminated string.
Please let me know if there is any problem with this Pull Request.
Thank you for providing such an easy to use tool to write custom tcp proxy ❤️