Conversation
Comment on lines
+4
to
+8
| public class Calculator { | ||
|
|
||
| static List<Product> products = new ArrayList<>(); | ||
| static double calculator = 0.0; | ||
| static int people = -1; |
There was a problem hiding this comment.
В этом классе все поля и функции можно сделать не статичными. То есть создавать инстанс класса калькулятор, который будет в себе хранить список продуктов, будет уметь считать итоговую сумму.
| scanner.close(); | ||
| } | ||
|
|
||
| static void guests () { |
There was a problem hiding this comment.
Все функции принято называть глаголами, потому что это действия
| try { | ||
| Double.parseDouble(s); | ||
| } catch (NumberFormatException e) { | ||
| return -1; //не число |
There was a problem hiding this comment.
чтобы здесь не писать комментарии, эти специальные коды для этой функции можно вынести в константы, например
private static final int NOT_A_NUMBER = -1;
Comment on lines
+3
to
+4
| String name; | ||
| double price; |
There was a problem hiding this comment.
Лучше сделать приватными, чтобы доступ осуществлялся только через функции-геттеры
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.