Prevent arrow and space keys from scrolling#11
Closed
sftrabbit wants to merge 1 commit intoincrepare:masterfrom
Closed
Prevent arrow and space keys from scrolling#11sftrabbit wants to merge 1 commit intoincrepare:masterfrom
sftrabbit wants to merge 1 commit intoincrepare:masterfrom
Conversation
When the exported game is contained in a page larger than the current viewport (such as when hosted on Kongregate), the arrow keys and space bar cause the page to scroll. To avoid this, prevent propagation of these events. The default behaviour must be prevented at the beginning of onKeyDown because any key in the repeat key buffer will not be checked by checkKey (so holding down keys would cause it to scroll).
Owner
|
cool, manually pulling this as we speak. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the exported game is contained in a page larger than the current
viewport (such as when hosted on Kongregate), the arrow keys and
space bar cause the page to scroll. To avoid this, prevent propagation
of these events.
The default behaviour must be prevented at the beginning of onKeyDown
because any key in the repeat key buffer will not be checked by
checkKey (so holding down keys would cause it to scroll).