Merged
Conversation
|
|
||
| object MPN { | ||
| // Some domain specific keywords known to be invalid | ||
| val BlackListedMpns = Set("unknown", "none", "does not apply", "non applicable", "various") |
There was a problem hiding this comment.
Lets also add n/a and na to this list
| else words.forall(w => w == WordUtils.capitalizeFully(w) && !StringUtils.isNumeric(w)) | ||
| } | ||
|
|
||
| def standardizeMPN(input: String): String = { |
There was a problem hiding this comment.
Why not use the return type as Option[String]?
There was a problem hiding this comment.
While we add this as an UDF, that part of the code can have the return type as string.
| } | ||
|
|
||
| it should "validate identifier" in { | ||
| MPN.isValidIdentifier("") should be (false) |
There was a problem hiding this comment.
lets also add the null test case
Author
|
@codingnirvana please check now |
|
LGTM. Merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.