Merged
Conversation
Add destination prefix option to publish task
We now look for an environment variable - AWS_STORAGE_CLASS whose values can be one of standard, rrs or glacier. The default behaviour if none specified is standard. Fixes #23
Remove redundant tests in GoEnvironmentTest Fix formatting of brace in FetchConfig.java
…leCannotBeDisabled
* Added changes on current material types to support Stage material * Added Stage material params * Removed StagePipeline param * Added new rendering logic to template * Create StageFetchExecutor (still missing stage counter find feature) * Reverted changes on other fetch executor names * Added logic to find latest stage counter * Adjustments to UI
Contributor
|
LGTM. @ashwanthkumar @manojlds PTAL and share your feedback. Will merge this, if you guys are ok. |
Member
|
LGTM.
…On Thu, Jan 3, 2019, 12:42 PM Sriram ***@***.*** wrote:
LGTM. @ashwanthkumar <https://github.com/ashwanthkumar> @manojlds
<https://github.com/manojlds> PTAL and share your feedback. Will merge
this, if you guys are ok.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAko17F6YJb-Yl13YXEK2hqEZGm8pF0Tks5u_a1HgaJpZM4ZmZZ2>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a new PR to retain all history from gocd-s3-artifacts repo for utils module