Skip to content

Make stub file generation optional#168

Closed
matthiasdiener wants to merge 1 commit intoinducer:mainfrom
matthiasdiener:optional-stub
Closed

Make stub file generation optional#168
matthiasdiener wants to merge 1 commit intoinducer:mainfrom
matthiasdiener:optional-stub

Conversation

@matthiasdiener
Copy link
Copy Markdown
Contributor

@matthiasdiener matthiasdiener commented Jun 4, 2025

E.g., when cross-compiling

cc: conda-forge/islpy-feedstock#61

E.g., when cross-compiling
@alexfikl
Copy link
Copy Markdown
Collaborator

alexfikl commented Jun 4, 2025

Silly suggestion, but how uncomfortable would it be to just add the pyi files to the repo? They could be regenerated when someone fiddles with the bindings (maybe with quick diff on the CI to check that they're up to date?).

@matthiasdiener
Copy link
Copy Markdown
Contributor Author

Silly suggestion, but how uncomfortable would it be to just add the pyi files to the repo? They could be regenerated when someone fiddles with the bindings (maybe with quick diff on the CI to check that they're up to date?).

I agree, that would probably be better. I think the content of the pyi file may depend on options selected during build, e.g. using shipped isl or not.

@alexfikl
Copy link
Copy Markdown
Collaborator

alexfikl commented Jun 4, 2025

I think the content of the pyi file may depend on options selected during build, e.g. using shipped isl or not.

Ah, yeah, good point :\ That doesn't sound like it would work then..

@matthiasdiener
Copy link
Copy Markdown
Contributor Author

Closing, done in #171.

@matthiasdiener matthiasdiener deleted the optional-stub branch June 12, 2025 19:41
@inducer
Copy link
Copy Markdown
Owner

inducer commented Jun 12, 2025

Whoops, sorry. I totally missed this PR in the rush to get things working again...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants