Added support for designated range initializers#53
Merged
inducer merged 1 commit intoinducer:masterfrom Aug 9, 2020
Merged
Conversation
inducer
reviewed
Aug 8, 2020
Owner
inducer
left a comment
There was a problem hiding this comment.
Thanks for working on this! This looks good to me for the most part. Please address the Flake8 failure and respond to my one comment. After that, it's ready to go in.
| ast = parser.parse(src) | ||
| ast.show() | ||
| gen = ext_c_generator.GnuCGenerator() | ||
| print(gen.visit(ast)) |
Owner
There was a problem hiding this comment.
I know none of the other tests do this, but it would be useful to test this as an identical parser/generator round-trip. If you're game, OK, otherwise, also fine.
Contributor
Author
There was a problem hiding this comment.
Sure! I'll take a look at getting this to round-trip.
Contributor
Author
|
Do you mind taking a look at the Flake8 log? I haven't used Flake8 before so I'm not really sure where the error is coming from. |
Owner
|
- Also added ability to round-trip test cases
780fec8 to
44036f7
Compare
Owner
|
Awesome. Thanks for working on that! LGTM, in it goes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #22