Skip to content

Disable global barrier check in m2l preprocess#133

Closed
inducer wants to merge 1 commit intomainfrom
no-gbarrier-in-mpole-preprocess
Closed

Disable global barrier check in m2l preprocess#133
inducer wants to merge 1 commit intomainfrom
no-gbarrier-in-mpole-preprocess

Conversation

@inducer
Copy link
Copy Markdown
Owner

@inducer inducer commented Aug 17, 2022

Here's another one similar to #132.

cc @isuruf @alexfikl

@inducer
Copy link
Copy Markdown
Owner Author

inducer commented Aug 17, 2022

cc @RKirby

@isuruf
Copy link
Copy Markdown
Collaborator

isuruf commented Aug 17, 2022

#131 is an alternative to this.

@alexfikl
Copy link
Copy Markdown
Collaborator

alexfikl commented Aug 17, 2022

Can confirm that #131 also does a nice job at improving things here!

133:	elapsed: 427.10s wall 0.98x CPU
131: 	elapsed: 372.73s wall 1.04x CPU

(this is just one run on dunkel using #129 (comment), so not rigorous, but still)

@inducer inducer closed this Aug 17, 2022
@inducer inducer deleted the no-gbarrier-in-mpole-preprocess branch August 17, 2022 20:58
@inducer
Copy link
Copy Markdown
Owner Author

inducer commented Aug 17, 2022

Sounds good. Let's go with #131 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants