Fix inaccuracies in ground_truth_schema.md#1
Merged
sriumcp merged 1 commit intoinference-sim:mainfrom Mar 6, 2026
Merged
Conversation
- Rename inference-perf-data/ to results/ (matches on-disk directory name) - Fix timestamps from "epoch seconds" to "monotonic clock seconds" (time.monotonic()) - Add missing RequestError class and error field on PerRequestMetrics - Mark LoadSummary rate/duration fields as optional (absent in summary metrics) Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inference-perf-data/toresults/to match actual on-disk directory nametime.monotonic())RequestErrorclass anderrorfield onPerRequestMetricsLoadSummary.send_duration/requested_rate/achieved_rateas optional (absent in summary metrics, only present in per-stage)Note
Everything in
ground_truth_schema.mdis already covered byschemas.py— this doc is a simplified reference card, not the source of truth for Pydantic models.ExpConfigExperimentConfigSharedPrefixDataSharedPrefixConfigLoadStageLoadStageLoadConfigLoadConfiginterval,sweep,circuit_breakers, etc.InferencePerfProfileInferencePerfConfigPercentileDistributionPercentileDistributionLatencyMetricsLatencyMetricsThroughputMetricsThroughputMetricsLoadSummaryLoadSummarySuccessMetrics/FailureMetricsLifecycleMetricsLifecycleMetricsRequestError/PerRequestMetrics/RequestInfoKVEventBatchvllm_logging.jsonVLLMLoggingConfigTest plan
schemas.pyPydantic models for consistency🤖 Generated with Claude Code