Conversation
423c185 to
e2dd513
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
=======================================
Coverage 90.42% 90.42%
=======================================
Files 39 39
Lines 3510 3510
=======================================
Hits 3174 3174
Misses 336 336 ☔ View full report in Codecov by Sentry. |
bednar
approved these changes
May 15, 2024
|
Hi, for some reason installing the package with the latest version ( python -m venv venv
. venv/bin/activate
python -m pip install influxdb_client
ls -l venv/lib/python3.11/site-packages/influxdb_client | grep typed
# NothingInstalling directly from the repo works though ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #622
Proposed Changes
This adds PEP 561 distributing and packaging type information, which specifically resolves issue with MyPy
error: Skipping analyzing "influxdb_client": module is installed, but missing library stubs or py.typed marker [import-untyped]The required marker really is just an empty file
py.typed. The same fix has been applied in v3 client.Checklist
pytest testscompletes successfully