Skip to content
This repository was archived by the owner on May 25, 2021. It is now read-only.

adding i18n to readme#96

Merged
james-martin-jd merged 3 commits intodevelopfrom
docs/readme-i18n
Feb 27, 2019
Merged

adding i18n to readme#96
james-martin-jd merged 3 commits intodevelopfrom
docs/readme-i18n

Conversation

@james-martin-jd
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@brownhoward brownhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Under "Adding a new language", the fullstop in "In this case. the icon maps" should be replaced with a comma.

  2. Under "Adding a new language", the last line mentions two steps so the section should be restructured with numbered items:
    ~~
    To add a new language:

  3. Add a new folder and translation file to the /public/locales folder, with translations in place.

  4. Inside language-dropdown.component.js, add the new language to const languages. This object contains the languages, with an id and an icon. In this case, the icon maps to a flag, which is mapped using flag-icon-css. This will add the language and flag to the dropdown.

Once those two steps are complete, the new language will be compatible with the generated application.
~~

@pablo-rodriguez-jd
Copy link
Copy Markdown
Contributor

Looks great. That's exactly what is doing and how it's doing it

@james-martin-jd james-martin-jd merged commit 0350ebb into develop Feb 27, 2019
@james-martin-jd james-martin-jd deleted the docs/readme-i18n branch February 27, 2019 20:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants