Skip to content

Fixes some layout and scrolling issues on playlists#394

Merged
insidegui merged 1 commit intomasterfrom
ah/bugfix/featured-scrolling
May 30, 2018
Merged

Fixes some layout and scrolling issues on playlists#394
insidegui merged 1 commit intomasterfrom
ah/bugfix/featured-scrolling

Conversation

@allenhumphreys
Copy link
Copy Markdown
Collaborator

@allenhumphreys allenhumphreys commented May 30, 2018 •
edited
Loading

Addresses:

  1. Vertical scroller would disappear when set to always visible
  2. Collection views would get messed up if scrollers set to always visible
  3. Bottom padding of page caused scroller to not reach bottom
  4. Collection views weren't scrollable until SOMETHING happens, such as window resize or contents get changed
  5. Outer scroll view bounced horizontally if your mouse wasn't over a collection view

@allenhumphreys allenhumphreys requested a review from insidegui May 30, 2018 16:32
@insidegui
Copy link
Copy Markdown
Owner

insidegui commented May 30, 2018

Good job!

@insidegui insidegui merged commit 93fb3fc into master May 30, 2018
@bcmn bcmn deleted the ah/bugfix/featured-scrolling branch June 2, 2018 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@insidegui insidegui insidegui approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@allenhumphreys @insidegui