Make pip-system-certs an optional extra#278
Merged
SchrodingersGat merged 1 commit intoinventree:masterfrom Aug 16, 2025
Merged
Conversation
1ded223 to
3270719
Compare
Member
|
@jacobfelknor is this all that is required? No code changes? |
Contributor
Author
|
To my understanding, yes. I think all this package does is configure Python to use the OS certificate store rather than it's own bundled store. I could really only see using the system store being helpful if your InvenTree instance used a certificate signed by an internal CA, which can be common in an enterprise setting. I don't need this and it actually was causing problems for me. @matmair may be able to clarify further if my understanding is incorrect. |
Member
|
@jacobfelknor thanks for the contribution :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #274
Make
pip-system-certsan optional dependency, allowing the user to tune the install to fit their environment