fix(cli-plugin-ionic1): use documentRoot and watchPatterns from ionic…#2314
Closed
norbertesperto wants to merge 1 commit intoionic-team:masterfrom
Closed
fix(cli-plugin-ionic1): use documentRoot and watchPatterns from ionic…#2314norbertesperto wants to merge 1 commit intoionic-team:masterfrom
norbertesperto wants to merge 1 commit intoionic-team:masterfrom
Conversation
Contributor
|
@norbert2gather This is looking good. I will test it soon. Thanks for submitting the PR. |
Contributor
|
Github didn't pick up the merge: a878a95 Thanks @norbert2gather !!! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use documentRoot and watchPatterns from ionic.config.json
In ionic1 projects the
documentRootandwatchPatternsconfig params are no longer working. This pull request aims to fix this.