Additional Proxy config parameter to allow connection pooling to be turned off#274
Closed
mur-dog wants to merge 3 commits intoionic-team:masterfrom
Closed
Additional Proxy config parameter to allow connection pooling to be turned off#274mur-dog wants to merge 3 commits intoionic-team:masterfrom
mur-dog wants to merge 3 commits intoionic-team:masterfrom
Conversation
|
Nice fix. I'll look at this today. |
|
@mur-dog - due to some pretty big changes to serve.js, I had to merge this in manually. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been using the proxy feature to avoid CORS issues to our API. API server is JHipster/Tomcat8.
However we have been running into an annoying problem - after 5 livereloads our application would stop working. Upon debugging I tracked down the issue to the proxy hanging - it looks like for some reason the proxy is not properly releasing/marking the Http request as complete. So the default HttpAgent spins up a new socket connection (up to 5) before getting into a blocked state.
This addition allows the proxy request to opt out of the default connection pooling by passing agent=false to the http request - and prevents the deadlock issue.