fix(md): fix flicker when navigating back in MD mode on certain Android devices#19553
Merged
liamdebeasi merged 1 commit intomasterfrom Oct 7, 2019
Merged
fix(md): fix flicker when navigating back in MD mode on certain Android devices#19553liamdebeasi merged 1 commit intomasterfrom
liamdebeasi merged 1 commit intomasterfrom
Conversation
Contributor
Author
|
Associated dev build: |
Contributor
|
I would like to know why this is a problem now, we haven't seen flickering before. I think it's important to understand why this is needed now, not against this change if we understand the root of the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #19491
What is the new behavior?
display: noneapplied to it at the end of the transition, ensuring that there is no flicker between when the animation is destroyed and when the view is removed from the DOM.Does this introduce a breaking change?
Other information