propose: add page.module.ts#63
Merged
imhoffd merged 2 commits intoionic-team:masterfrom Mar 26, 2018
rdlabo:pages_module
Merged
propose: add page.module.ts#63imhoffd merged 2 commits intoionic-team:masterfrom rdlabo:pages_module
imhoffd merged 2 commits intoionic-team:masterfrom
rdlabo:pages_module
Conversation
imhoffd
suggested changes
Mar 26, 2018
| @@ -1 +1,3 @@ | |||
| // homepage styles | |||
| app-page-home { | |||
Contributor
There was a problem hiding this comment.
This selector is not required. Angular CSS pulled in from styles or styleUrls are already scoped: https://angular.io/guide/component-styles#style-scope
Contributor
|
@rdlabo This is a good idea! |
Contributor
Author
|
@dwieeb thanks for review. and I see. not need selector in v4! |
Contributor
|
@rdlabo Awesome! Also, in the future can you make sure to use 2 spaces in TypeScript files? |
Contributor
Author
|
@dwieeb Oh! I will set my IDE use 2 spaces in TypeScript files! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Angular CLI can't judge
pagesand check@angular/router.So I think Ionic CLI's
pageconcentrate page.module.ts. and match selector name. ex)app-page-homefix ionic-team/ionic-cli#3019 (comment)