[MAD-PT DE] Teresa Pelinski#546
Closed
pelinski wants to merge 11 commits intoironhack-labs:masterfrom
Closed
Conversation
|
Buen trabajo Teresa, el ejercicio está completo, incluidos los dos bonus, y muy bien resuelto.
Sigue trabajando así, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-He hecho todas las iteraciones y los dos bonus
-Dificultad: fácil
-He hecho una rama tipo feature para cada iteración. Al terminar la iteración las he mergeado al dev y al final de todo el ejercicio, he mergeado el dev al master. Estaba todo muy bonito pero al final he indentado el código con prettier en VSC y ahora aparece aquí en github todo el código en verde por haber cambiado las líneas. La próxima vez corregiré los indent desde el principio en vez de esperarme al final.