Skip to content

Assignment #2: ML Pipelines, Feature Engineering, and Hyperparameter Tuning#3

Open
ishraqtm wants to merge 4 commits intomainfrom
assignment-2
Open

Assignment #2: ML Pipelines, Feature Engineering, and Hyperparameter Tuning#3
ishraqtm wants to merge 4 commits intomainfrom
assignment-2

Conversation

@ishraqtm
Copy link
Copy Markdown
Owner

Uoft-DSI | Production Data Engineering - Assignment #2

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@fyellow fyellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job! You’ve correctly implemented and tuned four pipelines but shap.explainers.Linear isn't compatible with KNN, which caused the error. To fix this, use shap.Explainer(best_overall_model.named_steps["regressor"], transformed_data) instead or switch to Ridge if you want SHAP coefficients.

@ishraqtm ishraqtm requested a review from fyellow June 24, 2025 05:13
@fyellow
Copy link
Copy Markdown

fyellow commented Jun 29, 2025

Good Job! Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants