Feat: Dynamic Search Keyboard Shortcut Icon#23
Merged
Abhijit-Jha merged 4 commits intoitshover:masterfrom Jan 3, 2026
Merged
Conversation
Contributor
|
@luth-v is attempting to deploy a commit to the itshover's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
further consideration: maybe we could remove the shortcut icon in the mobile screen since most of them can't use shortcut |
Member
|
Yes, we can do that Also, please refer to CONTRIBUTING.md to fix the build errors and make sure everything is tested properly before deploying. Thank you!! |
Member
|
@luth-v Also, we can apply the same logic here as well. |
Contributor
Author
|
Done, I created util instead to be reused in both navbar and icons-list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add dynamic icon for search keyboard shortcut based on client's OS (Mac/Linux)
Screenshot