Skip to content

fixed hotel and hostel conflict#59

Merged
Abhijit-Jha merged 1 commit intomasterfrom
fix/hostel-hotel-conflict
Jan 7, 2026
Merged

fixed hotel and hostel conflict#59
Abhijit-Jha merged 1 commit intomasterfrom
fix/hostel-hotel-conflict

Conversation

@Abhijit-Jha
Copy link
Copy Markdown
Member

@Abhijit-Jha Abhijit-Jha commented Jan 7, 2026 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Added a new animated hotel icon component with customizable visual properties (size, color, stroke width) and imperative animation controls for enhanced interactivity.

  • Bug Fixes

    • Corrected the icon registry entry name from "hostel-icon" to "hotel-icon" to resolve naming inconsistencies.
    • Standardized line ending formatting across multiple icon asset files.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
itshover-icons Ready Ready Preview, Comment Jan 7, 2026 10:51am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 7, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

This PR renames the hostel-icon registry item to hotel-icon, corrects the import statement in icons/index.ts from hostel-icon to hotel-icon, and introduces new TypeScript types (AnimatedIconProps, AnimatedIconHandle) for the animated icon component. Multiple icon registry files have line-ending normalization applied. Registry entries are updated consistently across both public/r/registry.json and registry.json.

Changes

Cohort / File(s) Change Summary
Import Correction
icons/index.ts		 Updated import source from hostel-icon to hotel-icon to resolve to correct module; ICON_LIST export unchanged
Registry Consolidation
registry.json, public/r/registry.json		 Renamed registry item from hostel-icon to hotel-icon; updated corresponding file path from icons/hostel-icon.tsx to icons/hotel-icon.tsx in both files
New Icon Component & Types
public/r/hotel-icon.json		 Introduced new animated hotel icon component with motion/react SVG animations, useImperativeHandle for imperative controls (startAnimation, stopAnimation), and public type exports (AnimatedIconProps interface with size/color/strokeWidth/className; AnimatedIconHandle interface with animation methods)
Line Ending Normalization
public/r/airplane-icon.json, public/r/passport-icon.json, public/r/travel-bag.json		 Normalized line endings in icon content from LF to CRLF; no functional or logical changes

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰 A hostel became a hotel so fine,
Registry renamed in perfect line,
Animations dance when hovered near,
New types flourish, crystal clear,
Line breaks aligned—a cleanup dream! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'fixed hotel and hostel conflict' directly addresses the core change: renaming hostel-icon to hotel-icon throughout the codebase to resolve the naming conflict between hotel and hostel.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Jan 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
public/r/passport-icon.json (1)

10-10: Line ending normalization detected across multiple files.

This file and others (airplane-icon.json, travel-bag.json) have been updated with CRLF line endings. While not functionally impactful, consider configuring .gitattributes to enforce consistent line endings across environments to avoid unnecessary diffs in future PRs.

📝 Suggested .gitattributes configuration

Add or update .gitattributes in the repository root:

# Auto-detect text files and normalize line endings to LF
* text=auto

# Explicitly set JSON files to LF
*.json text eol=lf

# Explicitly set TypeScript files to LF
*.ts text eol=lf
*.tsx text eol=lf
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4669fa0 and e7b02c2.

📒 Files selected for processing (8)
  • icons/hotel-icon.tsx
  • icons/index.ts
  • public/r/airplane-icon.json
  • public/r/hotel-icon.json
  • public/r/passport-icon.json
  • public/r/registry.json
  • public/r/travel-bag.json
  • registry.json
🔇 Additional comments (8)
public/r/airplane-icon.json (1)

10-10: Line ending normalization - no functional change.

This change is part of the same line ending normalization mentioned in passport-icon.json.

public/r/travel-bag.json (1)

10-10: Line ending normalization - no functional change.

This change is part of the same line ending normalization mentioned in passport-icon.json.

icons/index.ts (1)

190-190: Import path and file rename properly completed.

The import statement has been correctly updated to hotel-icon, and the physical file has been successfully renamed from hostel-icon.tsx to hotel-icon.tsx. This aligns with the component name HotelIcon and fixes the semantic conflict by using "hotel" as the more appropriate general term for lodging accommodations.

registry.json (1)

1725-1732: Registry correctly updated to reflect icon rename.

The registry item has been properly updated from hostel-icon to hotel-icon with matching changes in icons/index.ts and the corresponding icons/hotel-icon.tsx file present. Since registry.json is marked as an auto-generated file (per the file header), these changes should only be committed if they were generated via npm run registry:build. Any manual edits to this file violate its contract and should be reverted.

public/r/hotel-icon.json (3)

1-6: LGTM!

The registry metadata and dependencies are correctly configured. The motion dependency is appropriate for the animated icon implementation.

7-12: LGTM! Well-implemented animated icon component.

The HotelIcon component correctly uses React patterns (forwardRef, useImperativeHandle) and motion/react for animations. The imperative API exposure allows external control while hover handlers provide automatic animation triggers.

13-17: LGTM! Well-defined TypeScript interfaces.

The AnimatedIconProps and AnimatedIconHandle interfaces are properly typed and documented. Their placement in icons/types.ts makes them reusable across multiple animated icon components.

public/r/registry.json (1)

1724-1740: The rename from hostel-icon to hotel-icon is complete and consistent across the codebase.

The registry entry, source file (icons/hotel-icon.tsx), and all imports in icons/index.ts have been properly updated. No stale references to hostel-icon remain.

@Abhijit-Jha Abhijit-Jha merged commit 3a7d4f4 into master Jan 7, 2026
4 checks passed
@Abhijit-Jha Abhijit-Jha deleted the fix/hostel-hotel-conflict branch January 7, 2026 10:55
This was referenced Jan 8, 2026
Closed
Merged
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Abhijit-Jha