Skip to content

fix: X-sidebar animation toggle disables hover animations#68

Merged
Abhijit-Jha merged 2 commits intoitshover:masterfrom
rejioco:fix-Xsidebar-hover
Jan 10, 2026
Merged

fix: X-sidebar animation toggle disables hover animations#68
Abhijit-Jha merged 2 commits intoitshover:masterfrom
rejioco:fix-Xsidebar-hover

Conversation

@rejioco
Copy link
Copy Markdown
Contributor

@rejioco rejioco commented Jan 9, 2026 •
edited by coderabbitai bot
Loading

Description

Fixed the X-sidebar animation toggle so that icons stop animating when toggle is turned off.

Type of Change

  • Bug fix
  • New feature
  • New icon(s)
  • Documentation update

Issue

Fixes #67

Screen Recording

Before / After

  • Before:
issue.mov
  • After:
fixed.mov

Checklist

  • Code follows project style guidelines
  • npm run check passes
  • Tested hover animations with toggle off/on

Summary by CodeRabbit

  • Bug Fixes
    • Fixed hover behavior for sidebar icons so hover effects are enabled when animations are active and disabled when animations are off, ensuring consistent icon hover interactions.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Jan 9, 2026

@AyushGuleria2005 is attempting to deploy a commit to the itshover's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 9, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The PR fixes a bug in the X-sidebar example where the animation toggle failed to disable hover animations by inverting the disableHover prop to use !isAnimated for the SidebarItem icon and the top TwitterXIcon.

Changes

Cohort / File(s) Summary
X-Sidebar Hover Animation Fix
components/examples/x-sidebar.tsx		 Inverted disableHover prop logic from isAnimated to (!isAnimated) for both the SidebarItem icon and the top TwitterXIcon, ensuring hover animations are disabled when animations are turned off.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A little flip fixed the twitch and the spin,
Toggle off — the quiet begins within,
Icons now rest where stillness is due,
Toggle on — they prance, bright and new,
Hoppity joy for a sidebar that's true!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main fix: disabling hover animations when the X-sidebar animation toggle is turned off, matching the code changes.
Linked Issues check ✅ Passed The code changes directly address issue #67 by implementing the negation logic to disable hover animations (disableHover={!isAnimated}) when animation toggle is off.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the X-sidebar animation toggle behavior; no unrelated modifications were introduced.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1b34932 and ca13f0f.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • components/examples/x-sidebar.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • components/examples/x-sidebar.tsx

Comment @coderabbitai help to get the list of available commands and usage tips.

@Abhijit-Jha
Copy link
Copy Markdown
Member

Abhijit-Jha commented Jan 10, 2026

Great, please fix the formatting so I can merge it.

@rejioco
Copy link
Copy Markdown
Contributor Author

rejioco commented Jan 10, 2026 •
edited
Loading

@Abhijit-Jha I have fixed the formatting

@Abhijit-Jha
Copy link
Copy Markdown
Member

Abhijit-Jha commented Jan 10, 2026

Great! Could you please share one more reference video?

Here are the requirements:

  • Animation OFF:

    • Hover over the icons
    • Hover over the text

  • Animation ON:

    • Same hover behavior as above

@rejioco
Copy link
Copy Markdown
Contributor Author

rejioco commented Jan 10, 2026

@Abhijit-Jha yes sure

Screen.Recording.2026-01-10.at.10.17.52.PM.mov

@Abhijit-Jha
Copy link
Copy Markdown
Member

Abhijit-Jha commented Jan 10, 2026

Cool, merging

@Abhijit-Jha Abhijit-Jha merged commit 6e1239d into itshover:master Jan 10, 2026
2 of 3 checks passed
This was referenced Jan 13, 2026
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

X-sidebar animation toggle does not disable hover animations

2 participants

@rejioco @Abhijit-Jha