Skip to content

index_add#26394

Merged
NiteshK84 merged 40 commits intoivy-llc:mainfrom
imsoumya18:index_add#26392
Jan 9, 2024
Merged

index_add#26394
NiteshK84 merged 40 commits intoivy-llc:mainfrom
imsoumya18:index_add#26392

Conversation

@imsoumya18
Copy link
Copy Markdown
Contributor

@imsoumya18 imsoumya18 commented Oct 1, 2023 •
edited
Loading

PR Description

index_add method in Paddla FrontEnd

Related Issue

index_add #26392

Close #26392

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Twitter

github-actions[bot]
github-actions Bot reviewed Oct 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Oct 1, 2023
@imsoumya18
Copy link
Copy Markdown
Contributor Author

imsoumya18 commented Oct 5, 2023

@saeedashrraf please have a look at my PR

HaiderSultanArc
HaiderSultanArc suggested changes Oct 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@HaiderSultanArc HaiderSultanArc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge upstream/main into your branch please? 😄

@imsoumya18
Copy link
Copy Markdown
Contributor Author

imsoumya18 commented Oct 6, 2023

@HaiderSultanArc I have merged, have a look now

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 6, 2023 •
edited
Loading

Thank you for this PR, here is the CI results:

This pull request does not result in any additional test failures. Congratulations!

HaiderSultanArc
HaiderSultanArc suggested changes Oct 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@HaiderSultanArc HaiderSultanArc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of your tests are failing 🤔 . Can you have a look at your implementation?
image

HaiderSultanArc
HaiderSultanArc reviewed Oct 10, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@HaiderSultanArc HaiderSultanArc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge with upstream/main again? The issue of CI should be fixed now.

@imsoumya18
Copy link
Copy Markdown
Contributor Author

imsoumya18 commented Oct 10, 2023

Can you merge with upstream/main again? The issue of CI should be fixed now.

I have merged the main. But, I need to make some modifications to the test. Also, I have something to say to you about this frontend function. I shall DM u on Discord.

@imsoumya18
Copy link
Copy Markdown
Contributor Author

imsoumya18 commented Oct 11, 2023

@HaiderSultanArc all the tests are passing now but, please don't merge it now until I add this to Ivy Functional API and here replace the code with calling ivy.index_add API as I have told you on Discord.

@imsoumya18 imsoumya18 mentioned this pull request Dec 8, 2023
Closed
5 tasks
@NiteshK84
Copy link
Copy Markdown
Contributor

NiteshK84 commented Dec 26, 2023

Hi @imsoumya18, if you PR is ready, you can let me know for the review.

@NiteshK84 NiteshK84 self-assigned this Dec 26, 2023
@NiteshK84
Copy link
Copy Markdown
Contributor

NiteshK84 commented Jan 7, 2024

Hi @imsoumya18,
test cases for torch and paddle backends are failing, can you please look into it,
image
image

@imsoumya18
Copy link
Copy Markdown
Contributor Author

imsoumya18 commented Jan 9, 2024

@NiteshK84 it is now passing all tests

@NiteshK84
Copy link
Copy Markdown
Contributor

NiteshK84 commented Jan 9, 2024

Hi @imsoumya18,
image
LGTM!

@NiteshK84
Copy link
Copy Markdown
Contributor

NiteshK84 commented Jan 9, 2024

not sure why a lot of tests are failing in CI.

@NiteshK84 NiteshK84 merged commit 11d30f9 into ivy-llc:main Jan 9, 2024
@imsoumya18 imsoumya18 mentioned this pull request Jan 9, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

+1 more reviewer

@HaiderSultanArc HaiderSultanArc HaiderSultanArc requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Fayad-Alman Fayad-Alman

@NiteshK84 NiteshK84

Labels

Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

index_add

6 participants

@imsoumya18 @NiteshK84 @HaiderSultanArc @saeedashrraf @Fayad-Alman @ivy-leaves