Conversation
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Please make the requested changes to the assignment_2.ipynb file. Once you commit your changes, I can re-review them and mark it. Thank you.
| " a = f.readlines()\n", | ||
| " # YOUR CODE HERE: Iterate through the variable using a for loop and print each row for inspection\n", | ||
| " for row in a:\n", | ||
| " print(a)" |
There was a problem hiding this comment.
There is a bug here. The variable 'a' contains full list of all lines. The statement print(a) will print the entire list repeatedly for each row. Instead of print(a), it should be print(row)
| "name": "stdout", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "[4. 4.225 3.9 3.7 4.075 3.95 4.55 3.45 3.975 4.525 4.425 4.225\n", |
There was a problem hiding this comment.
This output cell doesn't have any associated code.
| "name": "stdout", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "[5.45 5.425 6.1 5.9 5.55 6.225 5.975 6.65 6.625 6.525 6.775 5.8\n", |
There was a problem hiding this comment.
This output cell doesn't show the output of the coded cell above. Please re-run the code and submit that.
|
Sorry for the delay, I got pretty sick. I think I've fixed everything--- when pushing a notebook, do I need to run all cells before saving so that you can see the output? |
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
The changes look good.
Yes. Please submit with output blocks that match the code-block I noticed that the PR contains changes to assignment-1.ipynb as well. It should only contain updates to assignment_2.ipynb. For future assignments, please switch to the main branch before creating the assignment-2 branch, so that assignment-2 is branched from main rather than from assignment-1. Thanks
Glad you are feeling better.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Create functions
What did you learn from the changes you have made?
np matrix operations
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
No
How were these changes tested?
Test function output on multiple files- in particular to ensure that the final function sometimes returns '
True'
A reference to a related issue in your repository (if applicable)
Checklist