This repository was archived by the owner on Aug 22, 2020. It is now read-only.
Client does not create a valid signature when spaces are in the URL.#1
Merged
jasonhancock merged 1 commit intojasonhancock:masterfrom Oct 19, 2012
Merged
Conversation
… with spaces as %20, not +. urllib.quote will not work as other characters, like /, still need to be encoded.
Owner
|
Sorry it took me so long to get to this. Thanks for the pull request. |
jasonhancock
added a commit
that referenced
this pull request
Oct 19, 2012
Properly escape spaces in the URL. Client does not create a valid signature when spaces are in the URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed while trying to register an ssh key with registerSSHKeyPair that the client was generating an invalid signature when a space was added in the parameters. The API is expecting spaces to be encoded with %20, not +. This commit replaces the encoded +'s with %20.