This repository was archived by the owner on Jul 30, 2024. It is now read-only.
Merged
Conversation
Contributor
Author
|
@jaybaird any thoughts on this PR? |
groovecoder
pushed a commit
to groovecoder/python-bloomfilter
that referenced
this pull request
Apr 10, 2018
Update change text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I attempt to port to python3 without using the six library. I also add a tox.ini so the tests will run for python 6, python7, and python3.4
Python 3 is nice, cleaner, faster, and does unicode better than python2.
The problem is that it is not backwards compatible with python2, so you have to smooth out rough edges when supporting both.
In this project the biggies were
xrange no longer exists. range does what xrange did
imports are absolute, I backported this with future so we could support both/
StringIO is different, for what we do here you want bytesIO as StringIO demands a unicode string (in python3 str is unicode and unicode does not exists. There is a separate string type bytes)
Setup.py needed an update as the ez_setup had some unsupported syntax\
The tests all pass for all environments. Though I will keep an eye on the project to see if any issues come up due to python3 stuff.