Skip to content

Assignment 2#2

Open
jbrillantes wants to merge 4 commits intomainfrom
assignment-2
Open

Assignment 2#2
jbrillantes wants to merge 4 commits intomainfrom
assignment-2

Conversation

@jbrillantes
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answer to Q1 looks good.

Please make the following review changes -

  1. The notebook file has errors when you run it. Please follow the instructions provided in python/SETUP.md file to setup the correct environment so that you don't get errors while importing Numpy module.
  2. Q2 is incomplete. You have yet to add code.
  3. Q3 - The requirement is for the function to return True/False. Please modify the function to meet the requirement.

If you need one-on-one help with the SETUP, please join during office hours so that one of the Learning support staff can assist you

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants